common/ompio: make --disable-mpi-io work in static builds #2010
Conversation
ompi/mca/common/ompio/Makefile.am
Outdated
| else | ||
|
|
||
| headers = | ||
| soruces = |
There was a problem hiding this comment.
@edgargabriel there is a minor typo, it should be sources=
fwiw, i made things a bit differently in #2018
|
@ggouaillardet's comment about the typo is correct -- it should be fixed. I like the general direction of @ggouaillardet's PR (#2018), but it's not quite right. If @ggouaillardet can't make that approach work, then I think this PR should be fine (once the typo is fixed). |
edgargabriel
force-pushed
the
pr/ompio-common-static-disable-mpi-io
branch
from
5a9bad3 to
fd10c1c
Compare
|
ok, thanks for the feedback. I fixed the typo, and we can either merge this commit to have a quick fix, followed by the nicer solution from @ggouaillardet . Otherwise, I am also happy to not commit this fix, and wait for the other solution. |
|
I think #2018 is pretty close / will be worked out shortly. We should probably close this one. |
3 participants
@jsquyres do you want to review this? You are way more experienced with the autogen/Makefile magic of Open MPI. As far as I can see, this commit fixes the problem with --disable-mpi-io for static builds, but I am not entirely sure whether it is the 'correct' solution.